Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix to 2218_team8 #2237

Closed
wants to merge 1 commit into from
Closed

Conversation

windlikelyc
Copy link

@windlikelyc windlikelyc commented Aug 13, 2018

What is the purpose of the change

#2218
When user use telnet to invoke org.apache.dubbo.demo.DemoService#sayHello and the parameter
is null, he gets a response called "null".The change is to make response more understandably.

Brief changelog

When catch NPE,return "parameters can't be null"

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2237 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2237      +/-   ##
============================================
- Coverage     54.57%   54.55%   -0.03%     
+ Complexity     5156     5153       -3     
============================================
  Files           568      568              
  Lines         25019    25021       +2     
  Branches       4456     4457       +1     
============================================
- Hits          13655    13649       -6     
- Misses         9323     9327       +4     
- Partials       2041     2045       +4
Impacted Files Coverage Δ Complexity Δ
.../remoting/telnet/support/TelnetHandlerAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) 3% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
...onfig/spring/extension/SpringExtensionFactory.java 85.71% <0%> (+10.71%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c16f78...87b95ff. Read the comment docs.

@windlikelyc windlikelyc changed the title 修复参数是null返回null的bug fix parameter null team8 Aug 14, 2018
@windlikelyc windlikelyc changed the title fix parameter null team8 bug fix to 2218_team8 Aug 14, 2018
@diecui1202 diecui1202 closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants