-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2489 fixed consumer mock=force not effected #2527
Conversation
#2489 provider可以使用mock=force,但consumer无法使用force,只能用default或true。 |
Codecov Report
@@ Coverage Diff @@
## master #2527 +/- ##
============================================
- Coverage 55.06% 55.01% -0.05%
+ Complexity 5282 5277 -5
============================================
Files 573 573
Lines 25490 25502 +12
Branches 4526 4526
============================================
- Hits 14035 14030 -5
- Misses 9360 9370 +10
- Partials 2095 2102 +7
Continue to review full report at Codecov.
|
@jsen-joker pls. check the ci failure.
|
return "true".equalsIgnoreCase(value) | ||
|| "default".equalsIgnoreCase(value); | ||
return (value != null) && ("true".equalsIgnoreCase(value) | ||
|| "force".equalsIgnoreCase(value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not suitable for adding 'force' as default value.
@zonghaishang could u pls. review this PR? |
I will take a look. |
Close via #2742 |
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.