Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2489 fixed consumer mock=force not effected #2527

Closed
wants to merge 4 commits into from

Conversation

jsen-joker
Copy link

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@jsen-joker
Copy link
Author

#2489 provider可以使用mock=force,但consumer无法使用force,只能用default或true。

@codecov-io
Copy link

codecov-io commented Sep 19, 2018

Codecov Report

Merging #2527 into master will decrease coverage by 0.04%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2527      +/-   ##
============================================
- Coverage     55.06%   55.01%   -0.05%     
+ Complexity     5282     5277       -5     
============================================
  Files           573      573              
  Lines         25490    25502      +12     
  Branches       4526     4526              
============================================
- Hits          14035    14030       -5     
- Misses         9360     9370      +10     
- Partials       2095     2102       +7
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/config/ServiceConfig.java 50.48% <ø> (+2.11%) 64 <0> (ø) ⬇️
...ava/org/apache/dubbo/common/utils/ConfigUtils.java 70.54% <0%> (-1.18%) 44 <2> (ø)
...g/apache/dubbo/config/AbstractInterfaceConfig.java 80.95% <50%> (+0.16%) 81 <0> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-8.48%) 12% <0%> (-1%)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 58.06% <0%> (-6.46%) 3% <0%> (ø)
...ubbo/config/spring/status/SpringStatusChecker.java 75.67% <0%> (-5.58%) 11% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-5.08%) 22% <0%> (-1%)
.../config/spring/status/DataSourceStatusChecker.java 71.79% <0%> (-4.68%) 6% <0%> (ø)
...exchange/support/header/HeaderExchangeChannel.java 79.16% <0%> (-4.35%) 35% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd60e58...38863c9. Read the comment docs.

@diecui1202
Copy link

@jsen-joker pls. check the ci failure.

[�[1;34mINFO�[m] There is 1 error reported by Checkstyle 8.9 with codestyle/checkstyle.xml ruleset.
[�[1;31mERROR�[m] src/main/java/org/apache/dubbo/config/ServiceConfig.java:[24,8] (imports) UnusedImports: Unused import - org.apache.dubbo.common.utils.ClassHelper.

return "true".equalsIgnoreCase(value)
|| "default".equalsIgnoreCase(value);
return (value != null) && ("true".equalsIgnoreCase(value)
|| "force".equalsIgnoreCase(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not suitable for adding 'force' as default value.

@diecui1202
Copy link

@zonghaishang could u pls. review this PR?

@zonghaishang
Copy link
Member

I will take a look.

@carryxyh
Copy link
Member

carryxyh commented Nov 7, 2018

Close via #2742

@carryxyh carryxyh closed this Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants