Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect descriptions for dubbo-serialization module. #2620

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

carryxyh
Copy link
Member

@carryxyh carryxyh commented Oct 9, 2018

Fix incorrect descriptions for dubbo-serialization module.
Simple fix which doesn't need test.

@carryxyh
Copy link
Member Author

carryxyh commented Oct 9, 2018

Will bring back to 2.6.x.

@codecov-io
Copy link

Codecov Report

Merging #2620 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2620      +/-   ##
============================================
+ Coverage     55.04%   55.07%   +0.02%     
  Complexity     5286     5286              
============================================
  Files           571      571              
  Lines         25521    25521              
  Branches       4530     4530              
============================================
+ Hits          14048    14055       +7     
+ Misses         9364     9356       -8     
- Partials       2109     2110       +1
Impacted Files Coverage Δ Complexity Δ
...onfig/spring/extension/SpringExtensionFactory.java 68.96% <0%> (-6.9%) 11% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 55.6% <0%> (-1.73%) 35% <0%> (-3%)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
.../java/org/apache/dubbo/config/ReferenceConfig.java 51.07% <0%> (+0.71%) 42% <0%> (ø) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 57.83% <0%> (+3.61%) 15% <0%> (+2%) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 54.92% <0%> (+12.67%) 17% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8abd590...d253718. Read the comment docs.

@carryxyh carryxyh merged commit 5a25e7d into apache:master Oct 9, 2018
@carryxyh carryxyh deleted the fix-description branch October 9, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants