Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dubbo-2798]fix apporiate NotWritablePropertyException #2800

Merged
merged 12 commits into from
Nov 20, 2018
Merged

[Dubbo-2798]fix apporiate NotWritablePropertyException #2800

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
66c7053
Merge pull request #1 from apache/master
kexianjun Aug 31, 2018
2fd0bb4
add getter and setter for ServiceConfig's interfaceName property#2353
kexianjun Sep 1, 2018
d8dd283
Merge branch 'master' of https://github.com/kexianjun/incubator-dubbo
kexianjun Sep 1, 2018
4e0a0bc
add interfaceName to ignoreAttributeNames and change the unit test
kexianjun Sep 7, 2018
6d1be10
Merge branch 'master' of https://github.com/apache/incubator-dubbo
kexianjun Sep 7, 2018
cd46b4f
delete the demo source code and update the unit test
kexianjun Sep 7, 2018
9fecd6b
unchange ServiceConfig
kexianjun Sep 7, 2018
e507489
Merge branch 'master' of https://github.com/apache/incubator-dubbo
kexianjun Sep 9, 2018
50729a7
update unit test
kexianjun Sep 10, 2018
3cfb36e
update unit test
kexianjun Sep 10, 2018
00d4611
Merge branch 'master' of https://github.com/apache/incubator-dubbo in…
kexianjun Nov 17, 2018
5b1917a
fix https://github.com/apache/incubator-dubbo/issues/2798
kexianjun Nov 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...spring/src/main/java/org/apache/dubbo/config/spring/schema/DubboBeanDefinitionParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ private static BeanDefinition parse(Element element, ParserContext parserContext
&& Modifier.isPublic(setter.getModifiers())
&& setter.getParameterTypes().length == 1) {
Class<?> type = setter.getParameterTypes()[0];
String property = StringUtils.camelToSplitName(name.substring(3, 4).toLowerCase() + name.substring(4), "-");
String propertyName = name.substring(3, 4).toLowerCase() + name.substring(4);
String property = StringUtils.camelToSplitName(propertyName, "-");
props.add(property);
Method getter = null;
try {
Expand Down Expand Up @@ -223,7 +224,7 @@ private static BeanDefinition parse(Element element, ParserContext parserContext
}
reference = new RuntimeBeanReference(value);
}
beanDefinition.getPropertyValues().addPropertyValue(property, reference);
beanDefinition.getPropertyValues().addPropertyValue(propertyName, reference);
}
}
}
Expand Down