Documentation/2935#dubbo rpc api #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2967 +/- ##
==========================================
- Coverage 64.09% 63.93% -0.16%
==========================================
Files 584 584
Lines 26059 26059
Branches 4562 4562
==========================================
- Hits 16702 16662 -40
- Misses 7184 7215 +31
- Partials 2173 2182 +9
Continue to review full report at Codecov.
|
This was referenced Dec 14, 2018
|
Hi, @khanimteyaz |
apache#2826) * Simplify the code logic of the method AbstractClusterInvoker#reselect. * Minor modification for code style.
* create AbstractRouter * router default method * router default method * router default method * mockinvoker
…ache#2931) * optimize findConfigedPorts method of ServiceConfig to log only one time when userandom port * move the log to method putRandomPort
* Improve UT grammer, fix compiler warnings. * Remove unnecessary braces.
* fix testCustomExecutor * fix ci
delete unused logic and take the logger out.
…r#isMatch (apache#2941) * enhance isMatch * remove useless imports
* add getter and setter for ServiceConfig's interfaceName property#2353 * add interfaceName to ignoreAttributeNames and change the unit test * delete the demo source code and update the unit test * unchange ServiceConfig * update unit test * update unit test * fix apache#2798 and enhance invoke command
* Replace anonymous class with method reference * Revert changes as per @beiwei30 code review
* Abstract retry task * Task for retry. * Fix sth. * Finish Optimize. fix ci failed. * Optimize retry for FailbackRegistry. The retry operation splits into specific operations, such as subscriptions and registrations. This approach allows for very precise retry control. * Optimize retry for FailbackRegistry. The retry operation splits into specific operations, such as subscriptions and registrations. This approach allows for very precise retry control. * Optimize logger warn's msg. * Optimize FailedNotifiedTask's run method. Optimize addXXXTask, directly return if we already have a retry task. * Optimize notify logic, just notify when the urls is not empty. * Optimize notify logic, just notify when the urls is not empty. * Optimize timer that use daemon thread.
…/khanimteyaz/incubator-dubbo into documentation/2935#dubbo-rpc-api
|
On it. Sorry for the delay in response.
…On Mon, Dec 17, 2018 at 7:50 AM 时无两丶 ***@***.***> wrote:
Hi, @khanimteyaz <https://github.com/khanimteyaz>
Very nice work, I'd like take a look.
Another thing, would u pls clear your commits? Seems like your pr has four
commits.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AdXcPdW5b5DTbcqEitzRwDCSFGapxd07ks5u5v9TgaJpZM4ZUNbi>
.
|
|
nice job :) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Added javadoc and documentation for dubbo-rpc-api filter package.
Brief changelog
Added documentation for java classes for developer, to provide high level idea what this current class suppose to do.
Verifying this change
Run build locally.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.