Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AnnotationBean.java delete duplicate code #3021

Merged
merged 1 commit into from
Dec 30, 2018

Conversation

Sidneyxt
Copy link
Contributor

@Sidneyxt Sidneyxt commented Dec 20, 2018

delete useless code

What is the purpose of the change

delete useless code

Brief changelog

XXXXX
image
duplicate code

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

delete useless code
@Sidneyxt Sidneyxt changed the title Update AnnotationBean.java Update AnnotationBean.java delete duplicate code Dec 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #3021 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3021      +/-   ##
==========================================
+ Coverage   64.24%   64.33%   +0.08%     
==========================================
  Files         584      584              
  Lines       26056    26056              
  Branches     4562     4562              
==========================================
+ Hits        16740    16762      +22     
+ Misses       7132     7111      -21     
+ Partials     2184     2183       -1
Impacted Files Coverage Δ
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 73.58% <0%> (-7.55%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 62.9% <0%> (-3.23%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 63.79% <0%> (-1.73%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.82% <0%> (-0.38%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 56.39% <0%> (+0.37%) ⬆️
...dubbo/remoting/exchange/support/DefaultFuture.java 68.45% <0%> (+0.67%) ⬆️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 66.66% <0%> (+0.83%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a06874...e0b764f. Read the comment docs.

Copy link
Contributor

@lixiaojiee lixiaojiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what it looks like

@Sidneyxt
Copy link
Contributor Author

I don't quite understand.

@khanimteyaz
Copy link
Contributor

Looks good to me.

@zonghaishang
Copy link
Member

AnnotationBean is deprecated, never should be used again.

@zonghaishang zonghaishang merged commit 0005166 into apache:master Dec 30, 2018
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants