Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix telnet trace times is always 1 #3038

Merged
merged 6 commits into from
Jan 9, 2019
Merged

fix telnet trace times is always 1 #3038

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86585b5
fix telnet trace times is always 1
LiZhenNet Dec 21, 2018
160bb40
use StringUtils determine if the string is empty
LiZhenNet Dec 29, 2018
2911b31
Merge branch 'upsteam' into feature-trace
LiZhenNet Jan 5, 2019
c833771
Fix 3105 , make invoke command with Json string parameter without "cl…
LiZhenNet Jan 5, 2019
6aebb78
Fix 3105 ，Keep the class key to support overloaded methods
LiZhenNet Jan 6, 2019
cbcb13b
optimize InvokerTelnetHandlerTest
LiZhenNet Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...pc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/TraceTelnetHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,18 @@ public String telnet(Channel channel, String message) {
String[] parts = message.split("\\s+");
String method;
String times;
// message like : XxxService , XxxService 10 , XxxService xxxMethod , XxxService xxxMethod 10
if (service == null || service.length() == 0) {
LiZhenNet marked this conversation as resolved.
Show resolved Hide resolved
service = parts.length > 0 ? parts[0] : null;
method = parts.length > 1 ? parts[1] : null;
} else {
times = parts.length > 2 ? parts[2] : "1";
LiZhenNet marked this conversation as resolved.
Show resolved Hide resolved
} else { //message like : xxxMethod, xxxMethod 10
method = parts.length > 0 ? parts[0] : null;
times = parts.length > 1 ? parts[1] : "1";
}
if (StringUtils.isInteger(method)) {
times = method;
method = null;
} else {
times = parts.length > 2 ? parts[2] : "1";
}
if (!StringUtils.isInteger(times)) {
return "Illegal times " + times + ", must be integer.";
Expand Down