-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routers zookeeper path #3173
Merged
beiwei30
merged 9 commits into
apache:2.7.0-release
from
chickenlj:routers_zookeeper_path
Jan 9, 2019
Merged
Routers zookeeper path #3173
beiwei30
merged 9 commits into
apache:2.7.0-release
from
chickenlj:routers_zookeeper_path
Jan 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ../routers/condition * ../routers/tag * ../routers/otherRouter
Codecov Report
@@ Coverage Diff @@
## 2.7.0-release #3173 +/- ##
===================================================
+ Coverage 63.63% 63.83% +0.19%
Complexity 75 75
===================================================
Files 652 651 -1
Lines 28317 28300 -17
Branches 4797 4795 -2
===================================================
+ Hits 18020 18065 +45
+ Misses 8021 7954 -67
- Partials 2276 2281 +5
Continue to review full report at Codecov.
|
/router/condition -> router-codition
beiwei30
reviewed
Jan 9, 2019
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/condition/config/AppRouter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief changelog
refer to commit logs
Verifying this change
run samples
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.