Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routers zookeeper path #3173

Merged
merged 9 commits into from
Jan 9, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

  • Change router rules stored in ZK to a more reasonable layered path
  • Move BlackWhiteList from router rule

Brief changelog

refer to commit logs

Verifying this change

run samples

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #3173 into 2.7.0-release will increase coverage by 0.19%.
The diff coverage is 45.45%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.0-release    #3173      +/-   ##
===================================================
+ Coverage            63.63%   63.83%   +0.19%     
  Complexity              75       75              
===================================================
  Files                  652      651       -1     
  Lines                28317    28300      -17     
  Branches              4797     4795       -2     
===================================================
+ Hits                 18020    18065      +45     
+ Misses                8021     7954      -67     
- Partials              2276     2281       +5
Impacted Files Coverage Δ Complexity Δ
...cluster/router/condition/config/ServiceRouter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...er/condition/config/model/ConditionRouterRule.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rpc/cluster/router/condition/config/AppRouter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 72.72% <ø> (ø) 0 <0> (ø) ⬇️
...er/condition/config/model/ConditionRuleParser.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 68.42% <100%> (ø) 0 <0> (ø) ⬇️
...apache/dubbo/rpc/cluster/router/tag/TagRouter.java 33.33% <100%> (ø) 0 <0> (ø) ⬇️
...ster/router/condition/config/ListenableRouter.java 33.33% <25%> (+4.76%) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 73.58% <0%> (-7.55%) 0% <0%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf474d...bd3090e. Read the comment docs.

@beiwei30 beiwei30 merged commit c679d0b into apache:2.7.0-release Jan 9, 2019
@chickenlj chickenlj deleted the routers_zookeeper_path branch January 9, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants