Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up for issue 195 #3614

Merged
merged 2 commits into from
Mar 8, 2019
Merged

follow up for issue 195 #3614

merged 2 commits into from
Mar 8, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Mar 7, 2019

What is the purpose of the change

follow up for issue #195

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3614 into master will increase coverage by 0.05%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3614      +/-   ##
============================================
+ Coverage     64.14%   64.19%   +0.05%     
  Complexity       71       71              
============================================
  Files           664      665       +1     
  Lines         28653    28844     +191     
  Branches       4769     4787      +18     
============================================
+ Hits          18379    18517     +138     
- Misses         8047     8088      +41     
- Partials       2227     2239      +12
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/config/AbstractServiceConfig.java 97.33% <ø> (-0.04%) 0 <0> (ø)
...g/apache/dubbo/config/AbstractReferenceConfig.java 94% <ø> (-0.34%) 0 <0> (ø)
.../org/apache/dubbo/config/spring/ReferenceBean.java 18.62% <0%> (-0.43%) 0 <0> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 54.81% <70%> (+0.8%) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 58.21% <71.42%> (+0.49%) 0 <0> (ø) ⬇️
...ubbo/rpc/cluster/support/RegistryAwareCluster.java 0% <0%> (-100%) 0% <0%> (ø)
...c/cluster/support/RegistryAwareClusterInvoker.java 0% <0%> (-25%) 0% <0%> (ø)
...bo/metadata/integration/MetadataReportService.java 78.04% <0%> (-6.17%) 0% <0%> (ø)
...e/dubbo/rpc/cluster/directory/StaticDirectory.java 66.66% <0%> (-5.13%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe049b8...56d48b9. Read the comment docs.

@chickenlj chickenlj merged commit a8b28cf into apache:master Mar 8, 2019
@beiwei30 beiwei30 deleted the followup-issue-195 branch March 8, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants