Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3960 #3965

Closed
wants to merge 5 commits into from
Closed

fix #3960 #3965

wants to merge 5 commits into from

Conversation

IanCao
Copy link
Contributor

@IanCao IanCao commented May 1, 2019

What is the purpose of the change

Merge rpc-native-thrift-for-apache-dubbo into incubator-dubbo #3960

Verifying this change

  1. add dubbo-rpc-native-thrift into dubbo-all/pom.xml
  2. add dubbo-rpc-native-thrift into dubbo-bom/pom.xml
  3. add libthrift_version, javax_annotation_api_version, junit_version into dubbo-dependency-pom/pom.xml
  4. add dubbo-rpc-native-thrift into dubbo-distribution/pom.xml
  5. and merge https://github.com/dubbo/rpc-native-thrift-for-apache-dubbo into this module.
  6. i have checked all test cases passed.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

<artifactId>junit</artifactId>
<version>${junit_version}</version>
<scope>test</scope>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junit 4 is not necessary.
Junit 5 is included in the parent pom and it can be used directly inside the new module without any extra declaration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. i'll changed

<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
<version>${javax_annotation_api_version}</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this declaration? I don't find the place where it was referenced.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. i'll remove..i'm just merge this from rpc-native-thrift-for-apache-dubbo to here. it's my fault.btw i find the thirft version of rpc-native-thrift and rpc-thrift is not same. should i make it same or declare 0.11 just in rpc-native-thrift module ??

@codecov-io
Copy link

Codecov Report

Merging #3965 into master will decrease coverage by 0.2%.
The diff coverage is 72.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3965      +/-   ##
============================================
- Coverage     63.97%   63.76%   -0.21%     
+ Complexity       98       71      -27     
============================================
  Files           715      744      +29     
  Lines         31493    32206     +713     
  Branches       5074     5124      +50     
============================================
+ Hits          20147    20536     +389     
- Misses         9048     9322     +274     
- Partials       2298     2348      +50
Impacted Files Coverage Δ Complexity Δ
...ubbo/rpc/protocol/nativethrift/ThriftProtocol.java 72.83% <72.83%> (ø) 0 <0> (?)
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 65.21% <0%> (-8.7%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/CodecSupport.java 77.77% <0%> (-3%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-2.69%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 59.84% <0%> (-2.37%) 0% <0%> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c7509...22f17ad. Read the comment docs.

@beiwei30
Copy link
Member

beiwei30 commented May 6, 2019

sorry about it. just noticed you had a pull request for the same issue after I merged #3977 from @Leishunyu.

@beiwei30
Copy link
Member

beiwei30 commented May 6, 2019

pls. improve #3977 if you see any inappropriate.

@beiwei30 beiwei30 closed this May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants