-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3960 #3965
fix #3960 #3965
Conversation
dubbo-dependencies-bom/pom.xml
Outdated
<artifactId>junit</artifactId> | ||
<version>${junit_version}</version> | ||
<scope>test</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Junit 4 is not necessary.
Junit 5 is included in the parent pom and it can be used directly inside the new module without any extra declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. i'll changed
dubbo-dependencies-bom/pom.xml
Outdated
<groupId>javax.annotation</groupId> | ||
<artifactId>javax.annotation-api</artifactId> | ||
<version>${javax_annotation_api_version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this declaration? I don't find the place where it was referenced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. i'll remove..i'm just merge this from rpc-native-thrift-for-apache-dubbo to here. it's my fault.btw i find the thirft version of rpc-native-thrift and rpc-thrift is not same. should i make it same or declare 0.11 just in rpc-native-thrift module ??
Codecov Report
@@ Coverage Diff @@
## master #3965 +/- ##
============================================
- Coverage 63.97% 63.76% -0.21%
+ Complexity 98 71 -27
============================================
Files 715 744 +29
Lines 31493 32206 +713
Branches 5074 5124 +50
============================================
+ Hits 20147 20536 +389
- Misses 9048 9322 +274
- Partials 2298 2348 +50
Continue to review full report at Codecov.
|
sorry about it. just noticed you had a pull request for the same issue after I merged #3977 from @Leishunyu. |
pls. improve #3977 if you see any inappropriate. |
What is the purpose of the change
Merge rpc-native-thrift-for-apache-dubbo into incubator-dubbo #3960
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.