Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3137]: step3 - seperate constants for remoting #4023

Merged
merged 3 commits into from
May 11, 2019

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

issue #3137: step 3 -remoting

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM CrazyHZM requested a review from beiwei30 May 10, 2019 09:14
@codecov-io
Copy link

Codecov Report

Merging #4023 into master will decrease coverage by 0.02%.
The diff coverage is 73.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4023      +/-   ##
===========================================
- Coverage     63.42%   63.4%   -0.03%     
- Complexity      564     565       +1     
===========================================
  Files           755     755              
  Lines         32425   32425              
  Branches       5145    5145              
===========================================
- Hits          20567   20560       -7     
- Misses         9496    9504       +8     
+ Partials       2362    2361       -1
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/apache/dubbo/remoting/Codec.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/monitor/dubbo/DubboMonitorFactory.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...rc/main/java/org/apache/dubbo/remoting/Codec2.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyClient.java 66.1% <ø> (ø) 11 <0> (ø) ⬇️
...ache/dubbo/common/constants/RegistryConstants.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...enter/support/nacos/NacosDynamicConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...java/org/apache/dubbo/remoting/etcd/Constants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractReferenceConfig.java 94% <ø> (ø) 0 <0> (ø) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 82.55% <ø> (ø) 0 <0> (ø) ⬇️
...che/dubbo/registry/nacos/NacosRegistryFactory.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1dd65...6862fc2. Read the comment docs.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beiwei30
Copy link
Member

pls. remember to remove constants from Constants.java.

@beiwei30 beiwei30 merged commit 8e3675e into apache:master May 11, 2019
@caojiele caojiele mentioned this pull request May 12, 2019
6 tasks
@CrazyHZM CrazyHZM deleted the constantsStep3Remoting branch May 14, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants