Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize some code styles #4655

Merged
merged 1 commit into from
Jul 25, 2019
Merged

optimize some code styles #4655

merged 1 commit into from
Jul 25, 2019

Conversation

fakefrog
Copy link
Contributor

optimize some code styles
1.Object 的 equals 方法容易抛出空指针异常，方法的调用方需使用确定值的对象（或常量）来调用 equals 方法
2.所有的覆写方法，必须加@OverRide 注解

beiwei30
beiwei30 approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beiwei30 beiwei30 merged commit d4904d4 into apache:master Jul 25, 2019
@dubbo-bot dubbo-bot mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beiwei30 beiwei30 beiwei30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fakefrog @beiwei30