Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if user define interface service discovery, not publish service name mapping info #8179

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

Fix #8178

@horizonzy horizonzy changed the title if user define interface service discovery, not use service name mapping. if user define interface service discovery, not publish service name mapping info Jun 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #8179 (6a7dbba) into 3.0 (532ce72) will increase coverage by 1.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8179      +/-   ##
============================================
+ Coverage     61.87%   63.25%   +1.38%     
  Complexity      313      313              
============================================
  Files          1074     1074              
  Lines         45167    45172       +5     
  Branches       6791     6793       +2     
============================================
+ Hits          27945    28574     +629     
+ Misses        14156    13428     -728     
- Partials       3066     3170     +104     
Impacted Files Coverage Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 63.76% <100.00%> (+0.30%) ⬆️
...ans/factory/annotation/ServiceBeanNameBuilder.java 89.28% <0.00%> (-10.72%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 60.86% <0.00%> (-8.70%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...ubbo/common/url/component/param/DynamicValues.java 79.16% <0.00%> (-4.17%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.10% <0.00%> (-1.83%) ⬇️
...dubbo/config/spring/util/DubboAnnotationUtils.java 28.94% <0.00%> (-1.06%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 67.48% <0.00%> (-0.99%) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 68.86% <0.00%> (-0.95%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532ce72...6a7dbba. Read the comment docs.

@AlbumenJ AlbumenJ merged commit bb6d62b into apache:3.0 Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always publish service name mapping info
3 participants