Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trust the response format from nacos server. #8230

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

Don't trust the response format from nacos server.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #8230 (05d3a16) into 3.0 (e2d1ec0) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8230      +/-   ##
============================================
- Coverage     63.58%   63.51%   -0.07%     
  Complexity      313      313              
============================================
  Files          1074     1074              
  Lines         45211    45216       +5     
  Branches       6807     6810       +3     
============================================
- Hits          28749    28721      -28     
- Misses        13272    13297      +25     
- Partials       3190     3198       +8     
Impacted Files Coverage Δ
...enter/support/nacos/NacosDynamicConfiguration.java 22.66% <0.00%> (-0.79%) ⬇️
...ubbo/registry/client/AbstractServiceDiscovery.java 87.50% <0.00%> (-12.50%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 65.21% <0.00%> (-8.70%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 87.17% <0.00%> (-4.28%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.46% <0.00%> (-2.19%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 72.61% <0.00%> (-1.20%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 60.76% <0.00%> (-0.96%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 80.67% <0.00%> (-0.43%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d1ec0...05d3a16. Read the comment docs.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 01874fc into apache:3.0 Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants