Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Endpoint default constructor. #8277

Merged
merged 1 commit into from
Jul 13, 2021
Merged

add Endpoint default constructor. #8277

merged 1 commit into from
Jul 13, 2021

Conversation

sh1yu
Copy link
Contributor

@sh1yu sh1yu commented Jul 13, 2021

What is the purpose of the change

fix the Endpoint constructor error during Consumer start with FORCE_APPLICATION.
this place need default Endpoint constructor:

Brief changelog

  1. add Endpoint default constructor.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sh1yu sh1yu marked this pull request as ready for review July 13, 2021 02:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #8277 (d2447b1) into 3.0 (2e8dca6) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8277      +/-   ##
============================================
- Coverage     64.05%   63.90%   -0.16%     
+ Complexity      312      310       -2     
============================================
  Files          1073     1073              
  Lines         45274    45276       +2     
  Branches       6814     6814              
============================================
- Hits          28999    28932      -67     
- Misses        13056    13118      +62     
- Partials       3219     3226       +7     
Impacted Files Coverage Δ
.../dubbo/registry/client/DefaultServiceInstance.java 74.54% <100.00%> (+4.17%) ⬆️
...ache/dubbo/remoting/transport/AbstractChannel.java 37.50% <0.00%> (-37.50%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-27.59%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 61.01% <0.00%> (-6.78%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 63.42% <0.00%> (-5.10%) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 43.47% <0.00%> (-4.35%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-4.35%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 57.89% <0.00%> (-3.83%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8dca6...d2447b1. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 590a7e5 into apache:3.0 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants