Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Lock-free ConfigManager and improve config checking #8289

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Jul 14, 2021

What is the purpose of the change

  • Change ConfigManager to lock-free with ConcurrentHashMap
  • Improve config equals() and toString() performance
  • Improve checking large numbers of reference/service configs

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@kylixs kylixs mentioned this pull request Jul 14, 2021
6 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #8289 (5fb6ab3) into 3.0 (026fb43) will decrease coverage by 0.20%.
The diff coverage is 89.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8289      +/-   ##
============================================
- Coverage     64.04%   63.84%   -0.21%     
+ Complexity      313      312       -1     
============================================
  Files          1073     1077       +4     
  Lines         45271    45486     +215     
  Branches       6813     6840      +27     
============================================
+ Hits          28994    29039      +45     
- Misses        13063    13212     +149     
- Partials       3214     3235      +21     
Impacted Files Coverage Δ
...org/apache/dubbo/config/context/ConfigManager.java 76.63% <89.28%> (-3.50%) ⬇️
...n/java/org/apache/dubbo/config/AbstractConfig.java 80.23% <90.24%> (-0.47%) ⬇️
...g/apache/dubbo/config/AbstractInterfaceConfig.java 87.27% <100.00%> (+0.33%) ⬆️
...o/registry/zookeeper/ZookeeperRegistryFactory.java 66.66% <0.00%> (-33.34%) ⬇️
...tore/zookeeper/ZookeeperMetadataReportFactory.java 66.66% <0.00%> (-33.34%) ⬇️
...ookeeper/ZookeeperDynamicConfigurationFactory.java 66.66% <0.00%> (-33.34%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-13.80%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 61.01% <0.00%> (-6.78%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026fb43...5fb6ab3. Read the comment docs.

@AlbumenJ AlbumenJ merged commit a5737d1 into apache:3.0 Jul 16, 2021
@kylixs kylixs deleted the 3.0-remove-lock-of-config-manager-0713 branch October 23, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants