Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Improve dynamic configuration initialization #8294

Merged

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Jul 14, 2021

What is the purpose of the change

  • Initialize dynamic configuration in DubboBootstrap only
  • Get dynamic configuration from Environment only

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@kylixs kylixs requested a review from chickenlj July 14, 2021 12:59
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #8294 (3df8d95) into 3.0 (3eff57a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8294      +/-   ##
============================================
- Coverage     64.03%   64.02%   -0.02%     
- Complexity      310      313       +3     
============================================
  Files          1077     1077              
  Lines         45525    45526       +1     
  Branches       6840     6843       +3     
============================================
- Hits          29152    29147       -5     
- Misses        13146    13154       +8     
+ Partials       3227     3225       -2     
Impacted Files Coverage Δ
...mmon/config/configcenter/DynamicConfiguration.java 72.22% <ø> (-7.78%) ⬇️
...overnance/DefaultGovernanceRuleRepositoryImpl.java 100.00% <100.00%> (ø)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 70.73% <100.00%> (+0.12%) ⬆️
...nfigcenter/nop/NopDynamicConfigurationFactory.java 50.00% <0.00%> (-50.00%) ⬇️
...nfig/configcenter/nop/NopDynamicConfiguration.java 25.00% <0.00%> (-37.50%) ⬇️
...figcenter/AbstractDynamicConfigurationFactory.java 75.00% <0.00%> (-25.00%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 89.47% <0.00%> (-4.39%) ⬇️
...keeper/ZookeeperServiceDiscoveryChangeWatcher.java 88.88% <0.00%> (-3.71%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eff57a...3df8d95. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 192cee2 into apache:3.0 Jul 16, 2021
@kylixs kylixs deleted the 3.0-improve-dynamic-configuration-init-0714 branch October 23, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants