Compatible with nacos grouping via group #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #8320 +/- ##
============================================
- Coverage 63.93% 63.51% -0.42%
- Complexity 311 312 +1
============================================
Files 1078 1099 +21
Lines 45728 46050 +322
Branches 6862 6953 +91
============================================
+ Hits 29235 29250 +15
- Misses 13237 13527 +290
- Partials 3256 3273 +17
Continue to review full report at Codecov.
|
AlbumenJ
requested changes
Jul 23, 2021
| @@ -183,6 +183,8 @@ | |||
|
|
|||
| String GROUP_KEY = "group"; | |||
|
|
|||
| String NACOS_GROUP_KEY = "nacos.group"; | |||
There was a problem hiding this comment.
It would be better if we move this constant to dubbo-registry-nacos module
There was a problem hiding this comment.
good idea. i will modify it.
horizonzy
reviewed
Jul 28, 2021
| @@ -91,7 +93,9 @@ public static ServiceInstance toServiceInstance(Instance instance) { | |||
| * @since 2.7.5 | |||
| */ | |||
| public static String getGroup(URL connectionURL) { | |||
| return connectionURL.getParameter("nacos.group", DEFAULT_GROUP); | |||
| // Compatible with nacos grouping via group. | |||
| String group = connectionURL.getParameter(GROUP_KEY, DEFAULT_GROUP); | |||
There was a problem hiding this comment.
Use dubbo as the default group will be better?
There was a problem hiding this comment.
If it is modified to dubbo, then the nacos registration center and configuration center side also need to be adjusted synchronously. This impact is relatively large.
AlbumenJ
approved these changes
Jul 30, 2021
haoyann
pushed a commit
to haoyann/dubbo
that referenced
this pull request
Aug 2, 2021
* Compatible with nacos grouping via group * move nacos.group to dubbo.registry.nacos module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Compatible with nacos grouping via group
see #8317
Brief changelog
Verifying this change
Checklist