Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Ensure generated config id is unique, checking existed config #8322

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Jul 20, 2021

What is the purpose of the change

Ensure generated config id is unique, checking existed config.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #8322 (6a88b7b) into 3.0 (9cb97e3) will decrease coverage by 0.38%.
The diff coverage is 67.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8322      +/-   ##
============================================
- Coverage     63.95%   63.57%   -0.39%     
+ Complexity      313      312       -1     
============================================
  Files          1078     1099      +21     
  Lines         45744    46054     +310     
  Branches       6864     6952      +88     
============================================
+ Hits          29255    29277      +22     
- Misses        13233    13506     +273     
- Partials       3256     3271      +15     
Impacted Files Coverage Δ
...org/apache/dubbo/config/context/ConfigManager.java 75.67% <60.00%> (-0.36%) ⬇️
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 69.48% <72.22%> (-0.31%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 60.86% <0.00%> (-4.35%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 68.46% <0.00%> (-2.71%) ⬇️
...ry/client/metadata/MetadataServiceNameMapping.java 73.68% <0.00%> (-2.68%) ⬇️
...stry/client/ServiceDiscoveryRegistryDirectory.java 47.36% <0.00%> (-1.90%) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0.00%> (-1.89%) ⬇️
...ava/org/apache/dubbo/common/utils/ConfigUtils.java 69.51% <0.00%> (-0.61%) ⬇️
...g/apache/dubbo/config/AbstractInterfaceConfig.java 86.75% <0.00%> (-0.52%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb97e3...6a88b7b. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 7e33452 into apache:3.0 Aug 6, 2021
@kylixs kylixs deleted the 3.0-check-existed-config-0720 branch October 23, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants