Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused modifiable param #8411

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

BurningCN
Copy link
Member

What is the purpose of the change

Remove unused modifiable param

@codecov-commenter
Copy link

Codecov Report

Merging #8411 (1eb5434) into 3.0 (e2d1ec0) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8411      +/-   ##
============================================
- Coverage     63.58%   63.05%   -0.54%     
+ Complexity      313      311       -2     
============================================
  Files          1074     1099      +25     
  Lines         45211    46022     +811     
  Branches       6807     6925     +118     
============================================
+ Hits          28749    29018     +269     
- Misses        13272    13741     +469     
- Partials       3190     3263      +73     
Impacted Files Coverage Δ
...mon/src/main/java/org/apache/dubbo/common/URL.java 39.19% <100.00%> (+0.18%) ⬆️
...ain/java/org/apache/dubbo/common/URLStrParser.java 85.27% <100.00%> (-0.23%) ⬇️
...figcenter/file/FileSystemDynamicConfiguration.java 0.00% <0.00%> (-59.53%) ⬇️
...nfigcenter/nop/NopDynamicConfigurationFactory.java 50.00% <0.00%> (-50.00%) ⬇️
...nfig/configcenter/nop/NopDynamicConfiguration.java 25.00% <0.00%> (-37.50%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-34.49%) ⬇️
...o/registry/zookeeper/ZookeeperRegistryFactory.java 66.66% <0.00%> (-33.34%) ⬇️
...tore/zookeeper/ZookeeperMetadataReportFactory.java 66.66% <0.00%> (-33.34%) ⬇️
...ookeeper/ZookeeperDynamicConfigurationFactory.java 66.66% <0.00%> (-33.34%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 60.00% <0.00%> (-25.72%) ⬇️
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d1ec0...1eb5434. Read the comment docs.

@AlbumenJ AlbumenJ merged commit b680b53 into apache:3.0 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants