Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0-Triple]Remove auto wrap when attachment is an object instance #8473

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

guohao
Copy link
Contributor

@guohao guohao commented Aug 11, 2021

What is the purpose of the change

  1. Do not wrap object in attachment
  2. Fix triple server thread pool name's typo
  3. Remove hanlded exception info from metadata

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@guohao guohao changed the title Remove auto wrap when attachment is an object instance & remove excpp… [3.0-Triple]Remove auto wrap when attachment is an object instance Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #8473 (41b18d7) into 3.0 (6808f8f) will decrease coverage by 0.08%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8473      +/-   ##
============================================
- Coverage     62.84%   62.75%   -0.09%     
+ Complexity      312      311       -1     
============================================
  Files          1112     1112              
  Lines         46633    46620      -13     
  Branches       7016     7012       -4     
============================================
- Hits          29306    29258      -48     
- Misses        14064    14095      +31     
- Partials       3263     3267       +4     
Impacted Files Coverage Δ
...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java 24.59% <0.00%> (-0.41%) ⬇️
.../apache/dubbo/rpc/protocol/tri/AbstractStream.java 45.45% <28.57%> (+2.59%) ⬆️
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...nt/metadata/StandardMetadataServiceURLBuilder.java 85.36% <0.00%> (-4.88%) ⬇️
...ster/router/condition/config/ListenableRouter.java 26.82% <0.00%> (-4.88%) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 43.47% <0.00%> (-4.35%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 57.89% <0.00%> (-3.83%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 63.42% <0.00%> (-3.25%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 65.76% <0.00%> (-2.71%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6808f8f...41b18d7. Read the comment docs.

@guohao guohao merged commit 08eb01b into apache:3.0 Aug 12, 2021
@AlbumenJ AlbumenJ added this to the 3.0.3 milestone Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants