Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0 triple] Optimize tri header constant & avoid tri header in attachments #8481

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[3.0 triple] Optimize tri header constant & avoid tri header in attachments #8481

merged 1 commit into from
Aug 12, 2021

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

Optimize tri header constant & avoid tri header in attachments

Brief changelog

  • change tri constant to enum
  • Unified processing of attachment value & Determine whether it is larger than the default header size

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #8481 (8652be1) into 3.0 (08eb01b) will decrease coverage by 0.01%.
The diff coverage is 50.98%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8481      +/-   ##
============================================
- Coverage     62.87%   62.85%   -0.02%     
- Complexity      312      313       +1     
============================================
  Files          1112     1113       +1     
  Lines         46620    46654      +34     
  Branches       7012     7017       +5     
============================================
+ Hits          29311    29324      +13     
- Misses        14050    14069      +19     
- Partials       3259     3261       +2     
Impacted Files Coverage Δ
...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java 0.00% <0.00%> (ø)
...protocol/tri/TripleHttp2ClientResponseHandler.java 41.02% <0.00%> (ø)
.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java 35.09% <0.00%> (-0.24%) ⬇️
.../apache/dubbo/rpc/protocol/tri/AbstractStream.java 38.55% <10.00%> (-6.91%) ⬇️
...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java 25.42% <16.66%> (+0.83%) ⬆️
...pc/protocol/tri/TripleHttp2FrameServerHandler.java 39.44% <33.33%> (ø)
...pache/dubbo/rpc/protocol/tri/TripleHeaderEnum.java 91.89% <91.89%> (ø)
...e/dubbo/rpc/protocol/tri/AbstractClientStream.java 58.44% <100.00%> (-2.06%) ⬇️
...e/dubbo/rpc/protocol/tri/AbstractServerStream.java 52.87% <100.00%> (-4.86%) ⬇️
...ubbo/rpc/protocol/tri/ClientTransportObserver.java 82.97% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08eb01b...8652be1. Read the comment docs.

@guohao guohao merged commit 0d6c4ab into apache:3.0 Aug 12, 2021
@AlbumenJ AlbumenJ added this to the 3.0.3 milestone Aug 15, 2021
@twz007
Copy link
Contributor

twz007 commented Nov 29, 2022

@EarthChen Hi, I would like to know why "remote.application" was replaced with "tri-consumer-appname", now it seems that there is a bug caused by this change. #11044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants