Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broadcast log format bug #8484

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

fix broadcast log format bug

see #8480

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #8484 (f9cdace) into 3.0 (2f099bd) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8484      +/-   ##
============================================
- Coverage     63.19%   62.82%   -0.37%     
- Complexity      310      312       +2     
============================================
  Files          1103     1112       +9     
  Lines         46230    46620     +390     
  Branches       6978     7012      +34     
============================================
+ Hits          29215    29291      +76     
- Misses        13729    14065     +336     
+ Partials       3286     3264      -22     
Impacted Files Coverage Δ
...o/rpc/cluster/support/BroadcastClusterInvoker.java 0.00% <0.00%> (ø)
...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java 24.59% <0.00%> (-28.99%) ⬇️
...ing/context/DubboBootstrapApplicationListener.java 60.00% <0.00%> (-22.00%) ⬇️
...apache/dubbo/rpc/protocol/tri/Http2HeaderMeta.java 55.55% <0.00%> (-19.45%) ⬇️
...apache/dubbo/rpc/protocol/tri/DefaultMetadata.java 58.33% <0.00%> (-11.67%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
.../apache/dubbo/rpc/protocol/tri/AbstractStream.java 45.45% <0.00%> (-11.07%) ⬇️
.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java 35.33% <0.00%> (-10.36%) ⬇️
...g/context/DubboInfraBeanRegisterPostProcessor.java 93.33% <0.00%> (-6.67%) ⬇️
...cluster/router/mesh/route/MeshAppRuleListener.java 77.50% <0.00%> (-6.29%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f099bd...f9cdace. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants