Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify the process of exported provider in single registry center #8501

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

pinxiong
Copy link
Member

What is the purpose of the change

see #8500

Brief changelog

  1. Check if the exporter exported by RegistryProtocolListener, ServiceListener and ExporterListener
  2. Check if the provider works well by Filter

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

1. Check if the exporter exported by RegistryProtocolListener, ServiceListener and ExporterListener
2. Check if the provider works well by Filter
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2021

Codecov Report

Merging #8501 (308a651) into 3.0 (cf8223e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8501      +/-   ##
============================================
+ Coverage     62.86%   62.88%   +0.02%     
  Complexity      312      312              
============================================
  Files          1113     1113              
  Lines         46655    46655              
  Branches       7019     7019              
============================================
+ Hits          29328    29338      +10     
+ Misses        14070    14065       -5     
+ Partials       3257     3252       -5     
Impacted Files Coverage Δ
.../remoting/transport/netty4/NettyServerHandler.java 62.79% <0.00%> (-9.31%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-2.18%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 61.42% <0.00%> (-1.43%) ⬇️
...ache/dubbo/registry/client/InstanceAddressURL.java 39.74% <0.00%> (-1.29%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 79.20% <0.00%> (+0.20%) ⬆️
...pache/dubbo/remoting/transport/AbstractClient.java 66.42% <0.00%> (+0.71%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 79.56% <0.00%> (+1.45%) ⬆️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) ⬆️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 71.17% <0.00%> (+2.70%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8223e...308a651. Read the comment docs.

@AlbumenJ AlbumenJ added this to the 3.0.3 milestone Aug 15, 2021
@AlbumenJ AlbumenJ merged commit a50810b into apache:3.0 Aug 15, 2021
@pinxiong pinxiong deleted the issue#8500 branch August 16, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants