Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【3.0】Verify additional configuration during service reference #8543

Merged
merged 5 commits into from
Aug 23, 2021

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #8543 (c4d6671) into 3.0 (2a5a355) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8543      +/-   ##
============================================
+ Coverage     63.00%   63.03%   +0.02%     
- Complexity      311      312       +1     
============================================
  Files          1116     1116              
  Lines         46725    46725              
  Branches       7031     7031              
============================================
+ Hits          29438    29451      +13     
+ Misses        14029    14019      -10     
+ Partials       3258     3255       -3     
Impacted Files Coverage Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
...n/java/org/apache/dubbo/config/AbstractConfig.java 81.03% <ø> (ø)
...ain/java/org/apache/dubbo/config/ModuleConfig.java 86.66% <ø> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 77.62% <ø> (ø)
...ava/org/apache/dubbo/common/utils/ConfigUtils.java 70.12% <100.00%> (ø)
...ava/org/apache/dubbo/config/ApplicationConfig.java 85.80% <100.00%> (+5.16%) ⬆️
.../remoting/transport/netty4/NettyServerHandler.java 62.79% <0.00%> (-9.31%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 60.86% <0.00%> (-8.70%) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <0.00%> (-5.80%) ⬇️
...va/org/apache/dubbo/registry/RegistryNotifier.java 85.71% <0.00%> (-2.86%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5a355...c4d6671. Read the comment docs.

@CrazyHZM CrazyHZM added this to the 3.0.3 milestone Aug 20, 2021
@AlbumenJ AlbumenJ merged commit 2d26e11 into apache:3.0 Aug 23, 2021
@CrazyHZM CrazyHZM deleted the 3.0_feature/unit_test_reference_config branch August 23, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants