Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When use delay to export service, catch the exception and log it. #8584

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

when use delay export service, the log info won't be print.

how to test it?
in dubbo-demo-xml-provider, modify the registry address to redis://127.0.0.1:6379?registry-type=service and run it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #8584 (bdff7fc) into 3.0 (0382a6b) will increase coverage by 0.27%.
The diff coverage is 61.40%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8584      +/-   ##
============================================
+ Coverage     63.00%   63.28%   +0.27%     
  Complexity      312      312              
============================================
  Files          1117     1118       +1     
  Lines         46754    46813      +59     
  Branches       7038     7057      +19     
============================================
+ Hits          29459    29624     +165     
+ Misses        14026    13898     -128     
- Partials       3269     3291      +22     
Impacted Files Coverage Δ
...ient/metadata/store/RemoteMetadataServiceImpl.java 64.78% <0.00%> (-5.64%) ⬇️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 82.14% <0.00%> (+4.61%) ⬆️
...nfig/bootstrap/builders/MetadataReportBuilder.java 92.68% <33.33%> (-4.69%) ⬇️
.../report/support/AbstractMetadataReportFactory.java 63.15% <46.15%> (-10.18%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 75.68% <50.00%> (-1.49%) ⬇️
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 70.16% <50.00%> (+0.31%) ⬆️
...apache/dubbo/registry/ListenerRegistryWrapper.java 55.07% <50.00%> (-4.63%) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 70.88% <61.90%> (-5.51%) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 71.08% <75.00%> (+0.32%) ⬆️
...registry/zookeeper/util/CuratorFrameworkUtils.java 84.78% <75.00%> (-8.25%) ⬇️
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c08fd2...bdff7fc. Read the comment docs.

@guohao guohao merged commit 067dba3 into apache:3.0 Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants