Adjust the scope of the spi extension #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #8600 +/- ##
============================================
+ Coverage 62.94% 62.97% +0.03%
Complexity 313 313
============================================
Files 1117 1117
Lines 46811 46811
Branches 7046 7046
============================================
+ Hits 29465 29481 +16
+ Misses 14057 14042 -15
+ Partials 3289 3288 -1
Continue to review full report at Codecov.
|
pinxiong
reviewed
Aug 27, 2021
| instance.getPort()))); | ||
| instance.getPort())); | ||
| Map<String, String> parameters = new HashMap<>(); | ||
| parameters.put("registry.listeners", "multipleConfigCenterServiceDiscoveryRegistry"); |
There was a problem hiding this comment.
It's better use the constant named SPI_NAME instead
| @@ -25,15 +25,15 @@ | |||
| import org.apache.dubbo.registry.client.ServiceDiscoveryRegistry; | |||
| import org.apache.dubbo.registry.client.metadata.store.InMemoryWritableMetadataService; | |||
|
|
|||
| @Activate | |||
| @Activate(value = "multipleConfigCenterServiceDiscoveryRegistry") | |||
| RegistryConfig registryConfig = new RegistryConfig(String.format("%s://%s:%s", | ||
| instance.getType(), | ||
| instance.getHostname(), | ||
| instance.getPort())); | ||
| Map<String, String> parameters = new HashMap<>(); | ||
| parameters.put("registry.protocol.listener", "singleConfigCenterExportProvider"); |
| @@ -27,7 +27,7 @@ | |||
| /** | |||
| * The {@link RegistryProtocolListener} for {@link SingleRegistryCenterExportProviderService} | |||
| */ | |||
| @Activate(order = 100) | |||
| @Activate(order = 100, value = "singleConfigCenterExportProvider") | |||
# Conflicts: # dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/integration/multiple/servicediscoveryregistry/MultipleRegistryCenterServiceDiscoveryRegistryRegistryServiceListener.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Adjust the scope of the spi extension used for testing.
Brief changelog
Verifying this change
Checklist