Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for service discovery process #8607

Merged
merged 7 commits into from
Aug 31, 2021

Conversation

chickenlj
Copy link
Contributor

Mainly test cases and comments

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #8607 (d397780) into 3.0 (3ac0c37) will increase coverage by 0.22%.
The diff coverage is 80.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8607      +/-   ##
============================================
+ Coverage     62.88%   63.11%   +0.22%     
+ Complexity      312      311       -1     
============================================
  Files          1118     1118              
  Lines         46840    46842       +2     
  Branches       7052     7061       +9     
============================================
+ Hits          29457    29562     +105     
+ Misses        14087    13983     -104     
- Partials       3296     3297       +1     
Impacted Files Coverage Δ
...o/common/url/component/DubboServiceAddressURL.java 67.30% <ø> (-0.62%) ⬇️
.../org/apache/dubbo/metadata/ServiceNameMapping.java 100.00% <ø> (ø)
.../apache/dubbo/registry/client/ServiceInstance.java 50.00% <ø> (ø)
...ta/MetadataServiceURLParamsMetadataCustomizer.java 90.00% <ø> (ø)
.../client/metadata/ServiceInstanceMetadataUtils.java 84.61% <ø> (+2.70%) ⬆️
...registry/client/migration/model/MigrationRule.java 72.43% <ø> (ø)
...e/dubbo/registry/integration/RegistryProtocol.java 59.69% <ø> (ø)
...pache/dubbo/remoting/transport/AbstractClient.java 65.71% <ø> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 65.38% <ø> (ø)
...n/java/org/apache/dubbo/metadata/MetadataInfo.java 65.53% <50.00%> (+13.24%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac0c37...d397780. Read the comment docs.

@chickenlj chickenlj merged commit 0f52c56 into apache:3.0 Aug 31, 2021
@chickenlj chickenlj deleted the 3.0-servicediscovery-testcases branch August 31, 2021 00:58
@chickenlj chickenlj added this to the 3.0.3 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants