-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: registry cast to AbstractRegistry error in telnet #8619
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #8619 +/- ##
============================================
- Coverage 63.87% 63.34% -0.53%
+ Complexity 314 312 -2
============================================
Files 1169 1178 +9
Lines 49239 49807 +568
Branches 7366 7452 +86
============================================
+ Hits 31450 31551 +101
- Misses 14368 14807 +439
- Partials 3421 3449 +28
Continue to review full report at Codecov.
|
Please change some methods implementation to template method from FailbackRegistry. public abstract void doRegister(URL url);
public abstract void doUnregister(URL url);
public abstract void doSubscribe(URL url, NotifyListener listener);
public abstract void doUnsubscribe(URL url, NotifyListener listener); |
2bd1292
to
817428d
Compare
@leizhiyuan Please resolve the conflict. |
# Conflicts: # dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistry.java
done |
What is the purpose of the change
fix #8614
Brief changelog
Verifying this change
Checklist