Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registry cast to AbstractRegistry error in telnet #8619

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

leizhiyuan
Copy link
Contributor

What is the purpose of the change

fix #8614

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #8619 (699953c) into 3.0 (9a0629c) will decrease coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8619      +/-   ##
============================================
- Coverage     63.87%   63.34%   -0.53%     
+ Complexity      314      312       -2     
============================================
  Files          1169     1178       +9     
  Lines         49239    49807     +568     
  Branches       7366     7452      +86     
============================================
+ Hits          31450    31551     +101     
- Misses        14368    14807     +439     
- Partials       3421     3449      +28     
Impacted Files Coverage Δ
...ubbo/registry/client/ServiceDiscoveryRegistry.java 81.37% <100.00%> (-0.50%) ⬇️
...he/dubbo/common/logger/support/FailsafeLogger.java 52.80% <0.00%> (-26.47%) ⬇️
.../apache/dubbo/common/context/LifecycleAdapter.java 25.00% <0.00%> (-25.00%) ⬇️
...ain/java/org/apache/dubbo/config/ModuleConfig.java 70.37% <0.00%> (-16.30%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 62.79% <0.00%> (-9.31%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.28% <0.00%> (-4.51%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 63.04% <0.00%> (-4.35%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0629c...699953c. Read the comment docs.

@AlbumenJ
Copy link
Member

AlbumenJ commented Sep 8, 2021

Please change some methods implementation to template method from FailbackRegistry.

    public abstract void doRegister(URL url);

    public abstract void doUnregister(URL url);

    public abstract void doSubscribe(URL url, NotifyListener listener);

    public abstract void doUnsubscribe(URL url, NotifyListener listener);

@CrazyHZM
Copy link
Member

@leizhiyuan Please resolve the conflict.

@CrazyHZM CrazyHZM added this to the 3.0.4 milestone Sep 22, 2021
@CrazyHZM CrazyHZM added status/waiting-for-feedback Need reporters to triage type/bug Bugs to being fixed labels Sep 22, 2021
# Conflicts:
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistry.java
@leizhiyuan
Copy link
Contributor Author

@leizhiyuan Please resolve the conflict.

done

@CrazyHZM CrazyHZM removed the status/waiting-for-feedback Need reporters to triage label Sep 26, 2021
@AlbumenJ AlbumenJ merged commit 8e4d9f6 into apache:3.0 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
4 participants