Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0-Triple] Catch some harmless exception #8663

Merged
merged 1 commit into from
Sep 6, 2021
Merged

[3.0-Triple] Catch some harmless exception #8663

merged 1 commit into from
Sep 6, 2021

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

  • add catch some harmless exception (like SocketException)

Brief changelog

Verifying this change

use https://github.com/grpc-ecosystem/grpc-health-probe and return status: SERVING,No exception log is generated on the server

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #8663 (635b7c3) into 3.0 (b8de0a7) will decrease coverage by 0.02%.
The diff coverage is 35.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8663      +/-   ##
============================================
- Coverage     63.49%   63.47%   -0.03%     
  Complexity      312      312              
============================================
  Files          1121     1121              
  Lines         46975    46988      +13     
  Branches       7093     7095       +2     
============================================
- Hits          29829    29826       -3     
- Misses        13846    13859      +13     
- Partials       3300     3303       +3     
Impacted Files Coverage Δ
...pc/protocol/tri/TripleServerConnectionHandler.java 19.04% <0.00%> (-3.18%) ⬇️
.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java 40.62% <50.00%> (+0.62%) ⬆️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-4.35%) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 46.51% <0.00%> (-0.67%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.93% <0.00%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8de0a7...635b7c3. Read the comment docs.

Copy link
Contributor

@guohao guohao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guohao guohao merged commit fe06df6 into apache:3.0 Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants