Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] fix destroy IllegalStateException and doOverrideIfNecessary NPE #8683

Merged
merged 1 commit into from
Sep 12, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 5, 2021

What is the purpose of the change

fix #8681 on master

@zrlw zrlw changed the title fix destroy NullPointerException and doOverrideIfNecessary [master] fix destroy NullPointerException and doOverrideIfNecessary Sep 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2021

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.07%. Comparing base (7d95364) to head (e09ea60).

Files Patch % Lines
...a/org/apache/dubbo/rpc/model/ApplicationModel.java 75.00% 0 Missing and 1 partial ⚠️
...e/dubbo/registry/integration/RegistryProtocol.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #8683      +/-   ##
============================================
+ Coverage     61.03%   61.07%   +0.03%     
+ Complexity      448      447       -1     
============================================
  Files          1097     1097              
  Lines         44398    44406       +8     
  Branches       6466     6469       +3     
============================================
+ Hits          27098    27119      +21     
+ Misses        14317    14301      -16     
- Partials       2983     2986       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrlw zrlw changed the title [master] fix destroy NullPointerException and doOverrideIfNecessary [master] fix destroy NPE and doOverrideIfNecessary IllegalStateException Sep 6, 2021
@zrlw zrlw changed the title [master] fix destroy NPE and doOverrideIfNecessary IllegalStateException [master] fix destroy IllegalStateExceptionand doOverrideIfNecessary NPE Sep 10, 2021
@zrlw zrlw changed the title [master] fix destroy IllegalStateExceptionand doOverrideIfNecessary NPE [master] fix destroy IllegalStateException and doOverrideIfNecessary NPE Sep 10, 2021
@AlbumenJ AlbumenJ merged commit e63a7be into apache:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants