Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caculate capacity in the default constructor of InternalThreadLocalMap #8697

Merged
merged 1 commit into from
Sep 11, 2021
Merged

Caculate capacity in the default constructor of InternalThreadLocalMap #8697

merged 1 commit into from
Sep 11, 2021

Conversation

kingkh1995
Copy link
Contributor

What is the purpose of the change

avoid foreseeable expanding in InternalThreadLocalMap

Brief changelog

use the same code which in method expandIndexedVariableTableAndSet to caculate capacity when create a InternalThreadLocalMap instance

Verifying this change

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #8697 (4e6b806) into 3.0 (d545d53) will decrease coverage by 0.07%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8697      +/-   ##
============================================
- Coverage     63.78%   63.70%   -0.08%     
  Complexity      314      314              
============================================
  Files          1142     1142              
  Lines         48077    48080       +3     
  Branches       7248     7249       +1     
============================================
- Hits          30664    30631      -33     
- Misses        14049    14077      +28     
- Partials       3364     3372       +8     
Impacted Files Coverage Δ
...bbo/common/threadlocal/InternalThreadLocalMap.java 74.02% <90.90%> (-15.17%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 62.79% <0.00%> (-9.31%) ⬇️
...va/org/apache/dubbo/common/utils/ExecutorUtil.java 62.06% <0.00%> (-3.45%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 76.64% <0.00%> (-3.29%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 68.46% <0.00%> (-2.71%) ⬇️
.../threadpool/manager/DefaultExecutorRepository.java 71.33% <0.00%> (-2.00%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0.00%> (-1.89%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 70.23% <0.00%> (-1.20%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d545d53...4e6b806. Read the comment docs.

@AlbumenJ AlbumenJ merged commit d173d16 into apache:3.0 Sep 11, 2021
@kingkh1995 kingkh1995 deleted the OPT-ITL branch October 12, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants