Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Add preferredProtocol fallback strategy #8699

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

plusmancn
Copy link
Contributor

@plusmancn plusmancn commented Sep 6, 2021

Fixes #8698
Fixes #8599
Related to #8666

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #8699 (f3b8fa5) into 3.0 (7c8662e) will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8699      +/-   ##
============================================
+ Coverage     63.66%   63.70%   +0.03%     
- Complexity      311      312       +1     
============================================
  Files          1141     1146       +5     
  Lines         47815    48152     +337     
  Branches       7162     7253      +91     
============================================
+ Hits          30441    30673     +232     
- Misses        14013    14114     +101     
- Partials       3361     3365       +4     
Impacted Files Coverage Δ
...ig/metadata/ServiceInstanceHostPortCustomizer.java 93.75% <85.71%> (+13.75%) ⬆️
.../org/apache/dubbo/rpc/model/ServiceDescriptor.java 75.60% <0.00%> (-24.40%) ⬇️
...he/dubbo/rpc/model/FrameworkServiceRepository.java 78.78% <0.00%> (-7.88%) ⬇️
...pache/dubbo/rpc/model/ModuleServiceRepository.java 64.04% <0.00%> (-7.70%) ⬇️
...n/java/org/apache/dubbo/rpc/model/ModuleModel.java 71.42% <0.00%> (-6.35%) ⬇️
...ache/dubbo/registry/client/InstanceAddressURL.java 51.65% <0.00%> (-6.04%) ⬇️
.../org/apache/dubbo/config/MetadataReportConfig.java 83.13% <0.00%> (-6.03%) ⬇️
...java/org/apache/dubbo/rpc/model/ProviderModel.java 38.23% <0.00%> (-5.84%) ⬇️
...n/java/org/apache/dubbo/metadata/MetadataInfo.java 61.16% <0.00%> (-5.83%) ⬇️
...a/org/apache/dubbo/rpc/model/ApplicationModel.java 77.66% <0.00%> (-5.49%) ⬇️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8662e...f3b8fa5. Read the comment docs.

Copy link
Contributor

@guohao guohao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guohao guohao requested a review from AlbumenJ September 7, 2021 06:01
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plusmancn
Copy link
Contributor Author

Don't merge now, the unit test still has a little problem. I am trying to solve this.

@plusmancn
Copy link
Contributor Author

Don't merge now, the unit test still has a little problem. I am trying to solve this.

Done! The problem of the unit test had been fixed.
It can be merged. @AlbumenJ

@guohao guohao merged commit 0fe0321 into apache:3.0 Sep 8, 2021
@plusmancn plusmancn deleted the fix-app-default-protocol branch September 8, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants