-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] Add preferredProtocol fallback strategy #8699
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #8699 +/- ##
============================================
+ Coverage 63.66% 63.70% +0.03%
- Complexity 311 312 +1
============================================
Files 1141 1146 +5
Lines 47815 48152 +337
Branches 7162 7253 +91
============================================
+ Hits 30441 30673 +232
- Misses 14013 14114 +101
- Partials 3361 3365 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Don't merge now, the unit test still has a little problem. I am trying to solve this. |
...pi/src/test/java/org/apache/dubbo/config/metadata/ServiceInstanceHostPortCustomizerTest.java
Show resolved
Hide resolved
Done! The problem of the unit test had been fixed. |
Fixes #8698
Fixes #8599
Related to #8666