-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] fix urlInvokerMap concurrent access issue #8701
[3.0] fix urlInvokerMap concurrent access issue #8701
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #8701 +/- ##
============================================
+ Coverage 63.77% 63.82% +0.05%
+ Complexity 315 314 -1
============================================
Files 1169 1169
Lines 49216 49222 +6
Branches 7361 7359 -2
============================================
+ Hits 31389 31418 +29
+ Misses 14406 14381 -25
- Partials 3421 3423 +2
Continue to review full report at Codecov.
|
Could you provide more detailed info? And why did you use the variable |
|
...ry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistryDirectory.java
Outdated
Show resolved
Hide resolved
...ubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryDirectory.java
Outdated
Show resolved
Hide resolved
ec2922f
to
e42d0a1
Compare
What is the purpose of the change
fix #8675
it might cause chaos that main thread does isAvailable() while main-EventThread does refreshInvoker() if both of them operate urlInvokerMap directly, especially while main-EventThread gets empty url lists to refresh.
github integration test log snippet: