Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] fix random assertion failure #8703

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 6, 2021

What is the purpose of the change

fix random assertion failure mentioned in #8689 on branch 3.0

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #8703 (6efff7a) into 3.0 (7ffa53a) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8703      +/-   ##
============================================
- Coverage     63.69%   63.66%   -0.04%     
- Complexity      313      314       +1     
============================================
  Files          1146     1146              
  Lines         48140    48140              
  Branches       7252     7252              
============================================
- Hits          30664    30646      -18     
- Misses        14113    14122       +9     
- Partials       3363     3372       +9     
Impacted Files Coverage Δ
...ubbo/registry/client/AbstractServiceDiscovery.java 87.50% <0.00%> (-12.50%) ⬇️
...n/java/org/apache/dubbo/common/bytecode/Proxy.java 66.43% <0.00%> (-4.80%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 89.47% <0.00%> (-4.39%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 58.69% <0.00%> (-4.35%) ⬇️
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 67.44% <0.00%> (-3.11%) ⬇️
...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java 58.33% <0.00%> (-2.39%) ⬇️
...org/apache/dubbo/config/context/ConfigManager.java 71.28% <0.00%> (-1.66%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 61.42% <0.00%> (-1.43%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 66.66% <0.00%> (-0.93%) ⬇️
...ava/org/apache/dubbo/common/utils/ConfigUtils.java 69.51% <0.00%> (-0.61%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffa53a...6efff7a. Read the comment docs.

@AlbumenJ AlbumenJ merged commit efa001b into apache:3.0 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants