Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Fix consumer using URL direct connection can not get ServerContext #8757

Merged
merged 5 commits into from
Sep 16, 2021
Merged

[3.0] Fix consumer using URL direct connection can not get ServerContext #8757

merged 5 commits into from
Sep 16, 2021

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@EarthChen
Copy link
Member Author

#8738

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #8757 (a2faffe) into 3.0 (fa37fc0) will increase coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.0    #8757   +/-   ##
=========================================
  Coverage     63.80%   63.80%           
- Complexity      313      314    +1     
=========================================
  Files          1159     1160    +1     
  Lines         48850    48894   +44     
  Branches       7327     7331    +4     
=========================================
+ Hits          31168    31198   +30     
- Misses        14272    14277    +5     
- Partials       3410     3419    +9     
Impacted Files Coverage Δ
...ubbo/rpc/cluster/directory/UrlStaticDirectory.java 34.14% <34.14%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 82.05% <54.54%> (+1.53%) ⬆️
...ubbo/registry/client/AbstractServiceDiscovery.java 87.50% <0.00%> (-12.50%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 67.44% <0.00%> (-3.11%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 77.45% <0.00%> (-2.91%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 70.23% <0.00%> (-1.20%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.12% <0.00%> (+0.19%) ⬆️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 63.54% <0.00%> (+0.49%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa37fc0...a2faffe. Read the comment docs.

# Conflicts:
#	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java

fix conflicts
@guohao guohao merged commit a9aba45 into apache:3.0 Sep 16, 2021
@EarthChen EarthChen deleted the fix-url-direct branch September 16, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants