Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize some code of the dubbo metadata module #8783

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Optimize some code of the dubbo metadata module #8783

merged 3 commits into from
Sep 20, 2021

Conversation

wangchengming666
Copy link
Member

Optimize some code of the dubbo metadata module

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #8783 (673bc4d) into 3.0 (675aead) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8783      +/-   ##
============================================
+ Coverage     63.89%   63.91%   +0.01%     
+ Complexity      313      312       -1     
============================================
  Files          1151     1151              
  Lines         48381    48381              
  Branches       7294     7294              
============================================
+ Hits          30914    30921       +7     
+ Misses        14088    14084       -4     
+ Partials       3379     3376       -3     
Impacted Files Coverage Δ
...pache/dubbo/metadata/report/support/Constants.java 100.00% <ø> (ø)
...etadata/report/support/AbstractMetadataReport.java 62.67% <100.00%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 63.04% <0.00%> (-4.35%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 93.69% <0.00%> (+0.90%) ⬆️
...vent/listener/ServiceInstancesChangedListener.java 80.28% <0.00%> (+0.96%) ⬆️
...pache/dubbo/remoting/transport/AbstractServer.java 62.85% <0.00%> (+1.42%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 79.56% <0.00%> (+1.45%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0.00%> (+1.98%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675aead...673bc4d. Read the comment docs.

@AlbumenJ AlbumenJ merged commit feb53c3 into apache:3.0 Sep 20, 2021
@wangchengming666 wangchengming666 deleted the fix-optimize-some-code branch September 20, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants