Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] do not show the warning at first replaceWithLazyClient() #8814

Merged
merged 11 commits into from
Sep 20, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 15, 2021

What is the purpose of the change

#8813

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #8814 (8204c16) into 3.0 (acd49fe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8814      +/-   ##
============================================
+ Coverage     63.75%   63.77%   +0.02%     
+ Complexity      315      314       -1     
============================================
  Files          1169     1169              
  Lines         49226    49226              
  Branches       7361     7360       -1     
============================================
+ Hits          31384    31395      +11     
+ Misses        14418    14406      -12     
- Partials       3424     3425       +1     
Impacted Files Coverage Δ
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 58.24% <100.00%> (+4.39%) ⬆️
...c/protocol/dubbo/ReferenceCountExchangeClient.java 65.00% <100.00%> (ø)
...ubbo/registry/client/AbstractServiceDiscovery.java 87.50% <0.00%> (-12.50%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 62.79% <0.00%> (-9.31%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
.../client/metadata/ServiceInstanceMetadataUtils.java 84.90% <0.00%> (-2.84%) ⬇️
...ubbo/config/deploy/DefaultApplicationDeployer.java 79.36% <0.00%> (-0.46%) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 68.70% <0.00%> (-0.33%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 61.72% <0.00%> (+0.95%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd49fe...8204c16. Read the comment docs.

@zrlw zrlw changed the title [3.0] do not warning at first replaceWithLazyClient() [3.0] do not show the warning at first replaceWithLazyClient() Sep 16, 2021
@AlbumenJ AlbumenJ merged commit 0f9f1ba into apache:3.0 Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants