Add test case for ZookeeperMetadataReportTest #8840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.test case 2.fix typo 3.remove unused param
Codecov Report
@@ Coverage Diff @@
## 3.0 #8840 +/- ##
============================================
+ Coverage 63.70% 63.72% +0.02%
Complexity 312 312
============================================
Files 1145 1169 +24
Lines 48188 49202 +1014
Branches 7255 7360 +105
============================================
+ Hits 30699 31355 +656
- Misses 14123 14417 +294
- Partials 3366 3430 +64
Continue to review full report at Codecov.
|
AlbumenJ
requested changes
Sep 20, 2021
| @@ -45,7 +45,7 @@ | |||
| default void publishAppMetadata(SubscriberMetadataIdentifier identifier, MetadataInfo metadataInfo) { | |||
| } | |||
|
|
|||
| default MetadataInfo getAppMetadata(SubscriberMetadataIdentifier identifier, Map<String, String> instanceMetadata) { | |||
| default MetadataInfo getAppMetadata(SubscriberMetadataIdentifier identifier) { | |||
There was a problem hiding this comment.
Please do not change this method signature. instanceMetadata contains some instance releated properties which will take effect when getting metadata
AlbumenJ
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
1.test case
2.fix typo
3.remove unused param