Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract constants of MigrationRule #8850

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

BurningCN
Copy link
Member

What is the purpose of the change

Extract constants of MigrationRule

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2021

Codecov Report

Merging #8850 (733883f) into 3.0 (1b100f8) will increase coverage by 0.04%.
The diff coverage is 41.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8850      +/-   ##
============================================
+ Coverage     63.70%   63.75%   +0.04%     
- Complexity      312      315       +3     
============================================
  Files          1145     1169      +24     
  Lines         48188    49226    +1038     
  Branches       7255     7361     +106     
============================================
+ Hits          30699    31383     +684     
- Misses        14123    14419     +296     
- Partials       3366     3424      +58     
Impacted Files Coverage Δ
...registry/client/migration/model/MigrationRule.java 72.43% <0.00%> (ø)
...istry/client/migration/model/SubMigrationRule.java 83.72% <100.00%> (ø)
...pring/context/event/DubboBootstrapStatedEvent.java 0.00% <0.00%> (-66.67%) ⬇️
...pring/context/event/DubboBootstrapStopedEvent.java 0.00% <0.00%> (-66.67%) ⬇️
...ing/context/DubboBootstrapApplicationListener.java 0.00% <0.00%> (-60.00%) ⬇️
.../DubboBootstrapStartStopListenerSpringAdapter.java 42.85% <0.00%> (-57.15%) ⬇️
...he/dubbo/rpc/cluster/support/MergeableCluster.java 50.00% <0.00%> (-50.00%) ⬇️
...nfig/spring/extension/SpringExtensionInjector.java 56.66% <0.00%> (-30.84%) ⬇️
...ubbo/config/spring/status/SpringStatusChecker.java 55.00% <0.00%> (-29.22%) ⬇️
...ig/metadata/ServiceInstanceHostPortCustomizer.java 68.75% <0.00%> (-25.00%) ⬇️
... and 268 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b100f8...733883f. Read the comment docs.

Copy link
Member

@wangchengming666 wangchengming666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit b685e4c into apache:3.0 Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants