Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] improve unit test efficiency #8877

Merged
merged 11 commits into from
Sep 23, 2021

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Sep 22, 2021

What is the purpose of the change

  • Upgrade maven to 3.8.1
  • Short shutdown wait time dubbo.service.shutdown.wait
  • Netty4 support shutdown timeout

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #8877 (c26bcbb) into 3.0 (9a0629c) will decrease coverage by 0.06%.
The diff coverage is 81.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8877      +/-   ##
============================================
- Coverage     63.87%   63.80%   -0.07%     
- Complexity      314      315       +1     
============================================
  Files          1169     1170       +1     
  Lines         49239    49375     +136     
  Branches       7366     7376      +10     
============================================
+ Hits          31450    31506      +56     
- Misses        14368    14428      +60     
- Partials       3421     3441      +20     
Impacted Files Coverage Δ
...apache/dubbo/common/config/ConfigurationUtils.java 73.77% <ø> (ø)
...main/java/org/apache/dubbo/rpc/ProtocolServer.java 0.00% <ø> (ø)
...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java 58.13% <50.00%> (-0.20%) ⬇️
...ubbo/rpc/protocol/rest/BaseRestProtocolServer.java 82.60% <50.00%> (-3.11%) ⬇️
...java/org/apache/dubbo/remoting/api/Connection.java 72.03% <62.96%> (+0.46%) ⬆️
...ache/dubbo/remoting/api/PortUnificationServer.java 82.85% <100.00%> (+1.31%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyServer.java 75.71% <100.00%> (+1.86%) ⬆️
...rg/apache/dubbo/rpc/protocol/AbstractProtocol.java 79.48% <100.00%> (+2.34%) ⬆️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 61.98% <100.00%> (+0.66%) ⬆️
.../dubbo/rpc/protocol/dubbo/DubboProtocolServer.java 64.28% <100.00%> (+5.95%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0629c...c26bcbb. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit eba466e into apache:3.0 Sep 23, 2021
@kylixs kylixs deleted the 3.0-improve-unit-test-efficiency-0922 branch October 23, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants