Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0-Triple] close stream when timeout #8888

Merged
merged 1 commit into from
Sep 23, 2021
Merged

[3.0-Triple] close stream when timeout #8888

merged 1 commit into from
Sep 23, 2021

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@guohao guohao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #8888 (efc8196) into 3.0 (4d42765) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8888      +/-   ##
============================================
+ Coverage     63.78%   63.82%   +0.03%     
  Complexity      313      313              
============================================
  Files          1170     1170              
  Lines         49330    49343      +13     
  Branches       7351     7373      +22     
============================================
+ Hits          31467    31494      +27     
+ Misses        14420    14410      -10     
+ Partials       3443     3439       -4     
Impacted Files Coverage Δ
...ubbo/remoting/exchange/support/DefaultFuture2.java 44.14% <46.15%> (+0.70%) ⬆️
...he/dubbo/rpc/protocol/tri/TripleClientHandler.java 63.33% <100.00%> (+0.62%) ⬆️
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-6.82%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 70.23% <0.00%> (-1.20%) ⬇️
...che/dubbo/common/compiler/support/JdkCompiler.java 63.55% <0.00%> (ø)
...va/org/apache/dubbo/registry/RegistryNotifier.java 84.61% <0.00%> (ø)
...bo/rpc/cluster/support/AbstractClusterInvoker.java 78.15% <0.00%> (+0.84%) ⬆️
...stry/client/ServiceDiscoveryRegistryDirectory.java 47.13% <0.00%> (+0.88%) ⬆️
...ache/dubbo/common/compiler/support/ClassUtils.java 49.73% <0.00%> (+1.05%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d42765...efc8196. Read the comment docs.

@guohao guohao merged commit 7894430 into apache:3.0 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants