Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Class.forName when publish ServiceDefinition #8894

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #8894 (7c4673d) into 3.0 (7894430) will increase coverage by 0.06%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8894      +/-   ##
============================================
+ Coverage     63.83%   63.89%   +0.06%     
- Complexity      313      315       +2     
============================================
  Files          1170     1170              
  Lines         49343    49349       +6     
  Branches       7373     7375       +2     
============================================
+ Hits          31497    31532      +35     
+ Misses        14406    14384      -22     
+ Partials       3440     3433       -7     
Impacted Files Coverage Δ
...ient/metadata/store/RemoteMetadataServiceImpl.java 65.33% <75.00%> (+0.05%) ⬆️
...etadata/store/InMemoryWritableMetadataService.java 84.17% <100.00%> (+0.30%) ⬆️
...ubbo/registry/client/AbstractServiceDiscovery.java 87.50% <0.00%> (-12.50%) ⬇️
...stry/client/ServiceDiscoveryRegistryDirectory.java 46.25% <0.00%> (-0.89%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 61.16% <0.00%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 89.18% <0.00%> (+0.90%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <0.00%> (+1.44%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 79.63% <0.00%> (+1.45%) ⬆️
...exchange/support/header/HeaderExchangeHandler.java 65.48% <0.00%> (+1.76%) ⬆️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7894430...7c4673d. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 0d550f9 into apache:3.0 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants