Add unit test and some optimizations #8945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RemoteMetadataServiceImpl
1.mock 2.field modifier 3.make Gson to be a common field
Codecov Report
@@ Coverage Diff @@
## 3.0 #8945 +/- ##
============================================
- Coverage 63.75% 63.47% -0.29%
Complexity 315 315
============================================
Files 1169 1182 +13
Lines 49226 50258 +1032
Branches 7361 7522 +161
============================================
+ Hits 31384 31901 +517
- Misses 14418 14888 +470
- Partials 3424 3469 +45
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
1.Add unit test for RemoteMetadataServiceImpl and MetadataServiceURLParamsMetadataCustomizer
2.fix typo
3.field modifier
4.make Gson to be a common field