Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#8961] Inject applicationModel into TripleHttp2Protocol by ScopeModelAware #8984

Merged
merged 5 commits into from
Oct 9, 2021

Conversation

plusmancn
Copy link
Contributor

What is the purpose of the change

Fixes #8961

Related to #8963

Brief changelog

Inject applicationModel into TripleHttp2Protocol by ScopeModelAware

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #8984 (d491835) into 3.0 (7c2f52d) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8984      +/-   ##
============================================
- Coverage     63.39%   63.36%   -0.03%     
+ Complexity      315      313       -2     
============================================
  Files          1185     1185              
  Lines         50323    50325       +2     
  Branches       7525     7525              
============================================
- Hits          31901    31890      -11     
- Misses        14941    14955      +14     
+ Partials       3481     3480       -1     
Impacted Files Coverage Δ
...he/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java 94.44% <50.00%> (-5.56%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 60.86% <0.00%> (-4.35%) ⬇️
...ava/org/apache/dubbo/config/DubboShutdownHook.java 42.42% <0.00%> (-3.04%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.18% <0.00%> (-1.46%) ⬇️
...bo/registry/support/CacheableFailbackRegistry.java 77.10% <0.00%> (-1.21%) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.03% <0.00%> (+0.32%) ⬆️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 71.42% <0.00%> (+1.19%) ⬆️
...pache/dubbo/remoting/transport/AbstractClient.java 62.14% <0.00%> (+1.42%) ⬆️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2f52d...d491835. Read the comment docs.

Copy link
Contributor

@guohao guohao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guohao guohao merged commit bb273ff into apache:3.0 Oct 9, 2021
@plusmancn plusmancn deleted the fix-npe-in-TripleHttp2Protocol branch October 9, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.0] The application level service discovery is not working in Triple Protocol (NPE problem)
3 participants