Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] check ClosedChannelException at close operation #9010

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Oct 10, 2021

What is the purpose of the change

#9009

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #9010 (66b71fc) into 3.0 (23a4ff0) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9010      +/-   ##
============================================
- Coverage     63.35%   63.34%   -0.02%     
+ Complexity      315      313       -2     
============================================
  Files          1186     1186              
  Lines         50364    50368       +4     
  Branches       7526     7527       +1     
============================================
- Hits          31910    31906       -4     
- Misses        14978    14981       +3     
- Partials       3476     3481       +5     
Impacted Files Coverage Δ
.../exchange/support/header/HeaderExchangeServer.java 66.36% <16.66%> (-2.51%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 68.42% <0.00%> (-5.27%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 66.50% <0.00%> (-2.43%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 63.36% <0.00%> (-1.99%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.38% <0.00%> (-0.98%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.39% <0.00%> (-0.90%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 80.46% <0.00%> (-0.20%) ⬇️
...pache/dubbo/remoting/transport/AbstractClient.java 62.14% <0.00%> (+1.42%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a4ff0...66b71fc. Read the comment docs.

Copy link
Member

@wangchengming666 wangchengming666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit a51851f into apache:3.0 Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants