Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connections config of method level #9011

Merged

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Method config can no longer set connections, the definition in xsd can be deleted directly.
Fix #2769

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM CrazyHZM added this to the 3.0.4 milestone Oct 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #9011 (b089aef) into 3.0 (17f85db) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9011      +/-   ##
============================================
- Coverage     63.39%   63.38%   -0.01%     
+ Complexity      315      313       -2     
============================================
  Files          1188     1188              
  Lines         50447    50450       +3     
  Branches       7533     7533              
============================================
  Hits          31980    31980              
- Misses        14980    14985       +5     
+ Partials       3487     3485       -2     
Impacted Files Coverage Δ
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) ⬇️
...vent/listener/ServiceInstancesChangedListener.java 77.11% <0.00%> (-1.28%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.38% <0.00%> (-0.98%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (ø)
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 67.47% <0.00%> (ø)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.03% <0.00%> (+0.32%) ⬆️
.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java 43.52% <0.00%> (+0.41%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 79.71% <0.00%> (+1.44%) ⬆️
.../apache/dubbo/remoting/transport/AbstractPeer.java 65.21% <0.00%> (+4.34%) ⬆️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0.00%> (+5.26%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f85db...b089aef. Read the comment docs.

@AlbumenJ AlbumenJ merged commit e94bc47 into apache:3.0 Oct 13, 2021
@CrazyHZM CrazyHZM deleted the 3.0_feature/remove_method_connections_config branch October 23, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About setting the connections to the method part.
3 participants