Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0-Triple]Fix compressor flag = 1 when compressor is none and format #9021

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

guohao
Copy link
Contributor

@guohao guohao commented Oct 11, 2021

What is the purpose of the change

Still doesnot work when didn't config compressor

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #9021 (dd432d2) into 3.0 (a6cd3a4) will decrease coverage by 0.17%.
The diff coverage is 24.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9021      +/-   ##
============================================
- Coverage     63.39%   63.22%   -0.18%     
- Complexity      313      314       +1     
============================================
  Files          1188     1188              
  Lines         50450    50417      -33     
  Branches       7533     7509      -24     
============================================
- Hits          31983    31875     -108     
- Misses        14980    15043      +63     
- Partials       3487     3499      +12     
Impacted Files Coverage Δ
...protocol/tri/TripleHttp2ClientResponseHandler.java 33.33% <0.00%> (-7.74%) ⬇️
...pc/protocol/tri/TripleHttp2FrameServerHandler.java 36.09% <18.51%> (-3.31%) ⬇️
...o/rpc/protocol/tri/TripleClientRequestHandler.java 58.73% <58.33%> (-5.79%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-20.69%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75.00% <0.00%> (-12.50%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 50.00% <0.00%> (-11.54%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 54.34% <0.00%> (-10.87%) ⬇️
...moting/transport/netty4/NettyEventLoopFactory.java 22.22% <0.00%> (-7.78%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6cd3a4...dd432d2. Read the comment docs.

@guohao guohao merged commit 4b7fec2 into apache:3.0 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants