Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0-Triple] Fix NPE in get configuration #9024

Merged
merged 6 commits into from
Oct 12, 2021

Conversation

guohao
Copy link
Contributor

@guohao guohao commented Oct 12, 2021

What is the purpose of the change

Fix IT error in triple compressor

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #9024 (0ec05a2) into 3.0 (e676350) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9024      +/-   ##
============================================
- Coverage     63.34%   63.33%   -0.01%     
  Complexity      315      315              
============================================
  Files          1189     1189              
  Lines         50461    50473      +12     
  Branches       7537     7540       +3     
============================================
+ Hits          31963    31969       +6     
- Misses        15010    15015       +5     
- Partials       3488     3489       +1     
Impacted Files Coverage Δ
...e/dubbo/rpc/protocol/tri/AbstractClientStream.java 63.73% <58.33%> (ø)
...o/rpc/protocol/tri/TripleClientRequestHandler.java 58.73% <100.00%> (ø)
.../dubbo/rpc/protocol/tri/service/TriHealthImpl.java 28.37% <0.00%> (-4.96%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-2.18%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 61.42% <0.00%> (-1.43%) ⬇️
...che/dubbo/config/deploy/DefaultModuleDeployer.java 64.28% <0.00%> (-0.17%) ⬇️
...ubbo/config/deploy/DefaultApplicationDeployer.java 79.32% <0.00%> (-0.14%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 67.96% <0.00%> (+0.48%) ⬆️
...dubbo/remoting/exchange/support/DefaultFuture.java 89.28% <0.00%> (+0.89%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 71.35% <0.00%> (+0.97%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e676350...0ec05a2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants