-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] Fix concurrency issues of service discovery #9684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chickenlj
commented
Feb 15, 2022
•
edited
Loading
edited
- Possible race conditions
- ReferenceConfigs have the same interface but different groups or versions subscribe/subscribe at the same time.
- Different interfaces that map to the same app list subscribe/unsubscribe at the same time.
- Mapping initialization and change notification
- Using file-based mapping cache to replace the one-only memory cache, most of the time, memory usage won't increase too much.
- Load mapping from the cache to accelerate starting process
- Async change notification to re-subscribe if mapping from remote was found changed.
- Multiple subscription support
- Make sure Consumer can find providers registered with multiple protocols through app-level address model
Codecov Report
@@ Coverage Diff @@
## 3.0 #9684 +/- ##
============================================
- Coverage 65.73% 65.06% -0.68%
+ Complexity 297 293 -4
============================================
Files 1192 1193 +1
Lines 52154 52369 +215
Branches 7918 7930 +12
============================================
- Hits 34285 34075 -210
- Misses 14186 14570 +384
- Partials 3683 3724 +41
Continue to review full report at Codecov.
|
…to fix-3.0-service-discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.